Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
DojoBackendAPI
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
External wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Dojo Project (HES-SO)
Projects
Backend
DojoBackendAPI
Compare revisions
8e4bf148fe846f5ce2faf8577c164bdcddce833c to ffef845266bb7ba23adc3c284472f79990bfd47c
Compare revisions
Changes are shown as if the
source
revision was being merged into the
target
revision.
Learn more about comparing revisions.
Source
dojo_project/projects/backend/dojobackendapi
Select target project
No results found
ffef845266bb7ba23adc3c284472f79990bfd47c
Select Git revision
Swap
Target
dojo_project/projects/backend/dojobackendapi
Select target project
Dojo_Project_Nguyen/backend/dojobackendapi
dojo_project/projects/backend/dojobackendapi
2 results
8e4bf148fe846f5ce2faf8577c164bdcddce833c
Select Git revision
Show changes
Only incoming changes from source
Include changes to target since source was created
Compare
Commits on Source (3)
Routes => Fix exercises counting (with deleted ones)
· 22884a65
michael.minelli
authored
3 months ago
22884a65
Merge branch 'fix-delete-exercises' into v5.0.1
· fee26a0f
michael.minelli
authored
3 months ago
fee26a0f
Merge branch 'v5.0.1'
· ffef8452
michael.minelli
authored
3 months ago
ffef8452
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
ExpressAPI/src/managers/ExerciseManager.ts
+3
-4
3 additions, 4 deletions
ExpressAPI/src/managers/ExerciseManager.ts
ExpressAPI/src/routes/ExerciseRoutes.ts
+1
-1
1 addition, 1 deletion
ExpressAPI/src/routes/ExerciseRoutes.ts
with
4 additions
and
5 deletions
ExpressAPI/src/managers/ExerciseManager.ts
View file @
ffef8452
...
...
@@ -15,11 +15,10 @@ class ExerciseManager {
})
as
unknown
as
Exercise
??
undefined
;
}
getFromAssignment
(
assignmentName
:
string
,
include
:
Prisma
.
ExerciseInclude
|
undefined
=
undefined
):
Promise
<
Array
<
Exercise
>>
{
// deleteFilter is a boolean that is true to get only deleted exercises, false to get only non-deleted exercises, and undefined to get all exercises
getFromAssignment
(
assignmentName
:
string
,
deleteFilter
:
boolean
|
undefined
=
undefined
,
include
:
Prisma
.
ExerciseInclude
|
undefined
=
undefined
):
Promise
<
Array
<
Exercise
>>
{
return
db
.
exercise
.
findMany
({
where
:
{
assignmentName
:
assignmentName
},
where
:
{
assignmentName
:
assignmentName
,
...(
deleteFilter
?
{
deleted
:
deleteFilter
}
:
{})
},
include
:
include
})
as
Promise
<
Array
<
Exercise
>>
;
}
...
...
This diff is collapsed.
Click to expand it.
ExpressAPI/src/routes/ExerciseRoutes.ts
View file @
ffef8452
...
...
@@ -133,7 +133,7 @@ class ExerciseRoutes implements RoutesManager {
private
async
checkExerciseLimit
(
assignment
:
Assignment
,
members
:
Array
<
Gitlab
.
UserSchema
>
):
Promise
<
Array
<
Gitlab
.
UserSchema
>>
{
const
exercises
:
Array
<
Exercise
>
|
undefined
=
await
ExerciseManager
.
getFromAssignment
(
assignment
.
name
,
{
members
:
true
});
const
exercises
:
Array
<
Exercise
>
|
undefined
=
await
ExerciseManager
.
getFromAssignment
(
assignment
.
name
,
false
,
{
members
:
true
});
const
reachedLimitUsers
:
Array
<
Gitlab
.
UserSchema
>
=
[];
if
(
exercises
.
length
>
0
)
{
for
(
const
member
of
members
)
{
...
...
This diff is collapsed.
Click to expand it.