Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found
Select Git revision
  • ask-user-to-delete-exercises-on-duplicates
  • jw_sonar
  • jw_sonar_backup
  • main
  • move-to-esm-only
  • open_tool_for_self_hosting
  • v5.0
  • v6.0
  • v4.1
  • v4.2
10 results

Target

Select target project
  • dojo_project/projects/shared/nodeclientsharedcode
1 result
Select Git revision
  • ask-user-to-delete-exercises-on-duplicates
  • jw_sonar
  • jw_sonar_backup
  • main
  • move-to-esm-only
  • open_tool_for_self_hosting
  • v5.0
  • v6.0
  • v4.1
  • v4.2
10 results
Show changes
Commits on Source (2)
...@@ -300,13 +300,18 @@ class AssignmentValidator { ...@@ -300,13 +300,18 @@ class AssignmentValidator {
this.newSubStep('SONAR_RUN', 'Run sonar analysis'); this.newSubStep('SONAR_RUN', 'Run sonar analysis');
const runSuccess = SonarAnalyzer.runAnalysis(assignment.sonarKey, assignment.language, assignmentFile.buildLine); const runSuccess = SonarAnalyzer.runAnalysis(assignment.sonarKey, assignment.language, assignmentFile.buildLine);
if ( runSuccess ) { if ( !runSuccess ) {
this.emitError(`Sonar gate failed`, 'Sonar analysis failure', AssignmentCheckerError.SONAR_ANALYSIS_FAILED); if ( !assignment.allowSonarFailure ) {
return; this.emitError(`Sonar gate failed`, 'Sonar analysis failure', AssignmentCheckerError.SONAR_ANALYSIS_FAILED);
return;
} else {
this.endSubStep('Sonar gate failed, you should check the sonar project', false);
}
} else {
this.endSubStep('Sonar gate passed', false);
} }
this.endSubStep('Sonar gate passed', false);
this.endStep('Sonar analysis success', false); this.endStep('Sonar analysis finished', false);
} }
......
...@@ -13,6 +13,7 @@ interface Assignment { ...@@ -13,6 +13,7 @@ interface Assignment {
gitlabLastInfoDate: string; gitlabLastInfoDate: string;
published: boolean; published: boolean;
useSonar: boolean; useSonar: boolean;
allowSonarFailure: boolean;
sonarKey: string; sonarKey: string;
sonarCreationInfo: SonarProjectCreation; sonarCreationInfo: SonarProjectCreation;
language: Language; language: Language;
......